🔴 Fix: Critical State Management Issue in PromptRow (#19)#23
Open
🔴 Fix: Critical State Management Issue in PromptRow (#19)#23
Conversation
Resolves #19 ## Changes - Refactor PromptRow to use @binding instead of @State - Remove intermediate editedPrompt state variable - Remove custom init method - Update PromptLibraryView to pass bindings using $viewModel.prompts - Direct binding eliminates stale state issues ## Benefits ✅ No stale state - changes reflect immediately ✅ Single source of truth - viewModel.prompts ✅ Predictable behavior - UI always in sync ✅ Automatic persistence - onChange handlers work correctly ✅ Simpler code - no init or state copying 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical state management bug in PromptRow where @State initialized from parameter created stale state issues.
Changes
PromptRowto use@Bindinginstead of@StateeditedPromptstate variableinitmethodPromptLibraryViewto pass bindings using$viewModel.promptsWhy This Fixes the Issue
The previous implementation used
@State private var editedPromptinitialized from a parameter ininit. This meant:The new implementation uses
@Binding var promptwhich:Test Plan
Benefits
Closes #19
🤖 Generated with Claude Code