prefer /usr/bin/pgrep to other pgrep if available #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the default pgrep, available since os x mountain lion. proctools' pgrep does not implement `-P` correctly, returns unrelated processes, breaks tree-kill's assumption, and may cause a large number of pgrep processes. Reported in pkrumins#17 (comment) Update golang/vscode-go#90 (comment)
Author
|
Is there any chance this gets reviewed? Thanks! |
Author
|
@TomasFlow Thanks for the approval. What's the next step? Will the new version be released? |
micalevisk
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default pgrep, available since os x mountain lion.
proctools' pgrep does not implement
-Pcorrectly, returnsunrelated processes, breaks tree-kill's assumption, and may
cause a large number of pgrep processes.
Reported in #17 (comment)
Update golang/vscode-go#90 (comment)