Apply hex faction colors to chat/tab formatting using styled Components#163
Merged
Apply hex faction colors to chat/tab formatting using styled Components#163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TextColoronComponentoutput and preserve configurable format tokens like{faction_color}and{reset}.Description
FactionTextFormatterto build and return a styledComponentinstead of producing a plain string with legacy formatting codes, by replacingapplyFormatto produceMutableComponentoutput.{faction_color}appliesStyle.withColor(TextColor.fromRgb(...)),{reset}resets toStyle.EMPTY, and placeholders{faction},{player},{message}, and{role}append text under the current style.appendLiteralhelper to append styled literal segments to the resultingMutableComponent.formatChatusesFactionConfig.SERVER.*formats andformatTabListstill uses the tab format string.Testing
./gradlew compileJava, which completed successfully (BUILD SUCCESSFUL).Codex Task