Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Invitesbutton without changing the main tab model.Description
INVITEStab fromFactionTaband added a compact label API viagetCompactLabelso the main tab row stays concise (src/main/java/com/mcprotector/client/gui/FactionTab.java).MemberSectionenum and two widgetsmembersSectionButtonandinvitesSectionButton, plus helperslayoutMemberSectionButtonsandupdateMemberSectionButtonState, to create a Members sub-section button row that can host more buttons (src/main/java/com/mcprotector/client/gui/FactionMainScreen.java).renderMembersswitch torenderInviteswhen the sub-section isINVITES, and updated visibility viaupdateVisibility/updateDynamicVisibilityso invite controls only show whenMembers -> Invitesis active.getContentStart) to reserve vertical space for the new sub-section row and added scaling helperspanelX/scaledWidthand layout recalculation (recalculateLayout) to keep control sizes responsive.src/main/java/com/mcprotector/client/gui/FactionMapRenderer.java).Testing
./gradlew compileJavaand the project compiled successfully (BUILD SUCCESSFUL).Codex Task