Tune faction GUI sizing for Auto scale (tabs + map)#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AutoGUI scale and tab labels/buttons could overflow or look misaligned. The change intends to tighten sizes so controls and the map fit better on compact/large resolutions.Description
TAB_BUTTON_WIDTH,TAB_BUTTON_HEIGHT,MIN_TAB_BUTTON_WIDTH,TAB_BUTTON_GAP,PANEL_CONTENT_WIDTHand minimum panel width inFactionMainScreento make top tabs and controls more compact.totalTabWidth = tabCount * tabButtonWidth + (tabCount - 1) * TAB_BUTTON_GAPand using that to center the tab row.panelContentWidth,horizontalScale, and helper methodsscaledWidth(int)andpanelX(int)to scale control widths/positions consistently, and converted many hardcoded control sizes/offsets to use those helpers.membersSectionButton,invitesSectionButton,layoutMemberSectionButtons,updateMemberSectionButtonState) and aMemberSectionenum to allow compact members/invites UI inside the Members tab.setButtonVisible(Button, boolean)andsetEditBoxVisible(EditBox, boolean)and adjusted dynamic visibility logic to account for the new member section state.FactionMapRendererby tightening the map width/height budget and loweringcellSizebounds so the grid renders smaller and fits better atAutoscale.FactionTabchanges (newcompactLabelandgetCompactLabel()), and use compact labels whentabButtonWidth < TAB_COMPACT_LABEL_THRESHOLD.Testing
./gradlew compileJavaand the build completed successfully.Codex Task