Allow Setting the Modal Id #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l overlay id. This will allow for styling of different modal windows if the need arises
….stop() to allow us to add additional click events to those elements if we need to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the SimpleModal class to give the ability to set the modal id and the modal overlay id. This gives the benefit of being able to change the styling for a specific modal window.
Adding in this ability has the side effect of creating multiple windows instead of using just the one. I think the trade of is worth the flexibility, it just needs to be left up to the implementer to be responsible.
This change in code also moves the naming of both the modal and the overlay to once central place instead of having $('simple-modal') calls through out the code.