KAAP-932 Gen certs at runtime

[srm6867]

Overview

What this PR does / why we need it

Special notes for your reviewer

Summary by Bito

This PR implements runtime certificate generation to replace static test certificate files, updating tests and supporting functions accordingly. Static certificate files have been removed from the testdata directory, resulting in simplified maintenance and a more modern testing approach.

[bito-code-review]

Code Review Agent Run #693b10

Actionable Suggestions - 0

Review Details

• Files reviewed - 10 · Commit Range: 4d5aaa5..4d5aaa5

  • pkg/httpclient/httpclient_test.go
  • pkg/httpclient/testcerts.go
  • pkg/httpclient/testdata/rootCA.key
  • pkg/httpclient/testdata/rootCA.pem
  • pkg/httpclient/testdata/rootCA.srl
  • pkg/httpclient/testdata/server.crt
  • pkg/httpclient/testdata/server.csr
  • pkg/httpclient/testdata/server.csr.cnf
  • pkg/httpclient/testdata/server.key
  • pkg/httpclient/testdata/v3.ext
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Golangci-lint (Linter) - ✖︎ Failed

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
New Feature - Runtime Certificate Generation Introduced	- httpclient_test.go - Modified tests to use runtime generated certificates by updating function signatures and test flows. - testcerts.go - Added a new utility that dynamically generates CA and server certificates for testing purposes.
Other Improvements - Static Certificate Files Removed	- rootCA.key - Removed static CA key file in favor of dynamic generation. - rootCA.pem - Removed static CA certificate file as part of the new runtime approach. - rootCA.srl - Eliminated the serial file, which is no longer necessary. - server.crt - Removed the static server certificate file to rely on runtime generation. - server.csr - Removed the certificate signing request file. - server.csr.cnf - Removed CSR configuration file. - server.key - Removed the static server key file. - v3.ext - Removed the certificate extension configuration file.

[sebastian-pf9]

if we really want to fix this, please not here but upstream directly.

can we close this?