Adding capability to use SSH for remote prep-node. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roopakparikh
requested review from
abhimanyubabbar,
mugdha-adhav,
pshanbhag and
sarun87
cmd/prepNode.go
Outdated
Contributor
There was a problem hiding this comment.
I would return an error here and not Fatalf ( FatalingF at top layer ). Wdyt ?
Contributor
Author
There was a problem hiding this comment.
I debated that, didn't see a point in doing that, but if you feel it is inconsistent, I can change it. Here is the reason why I did it this way.
- This is part of the file that is supposed to be doing validation and preparation.
- doing so in other places would be unnecessary, I will probably return and error with the same string and the function above will do a fatalf.
if this check was in another file, I would have absolutely agreed with you.
Contributor
Author
There was a problem hiding this comment.
ok @abhimanyu-babbar I have refactored it little bit PTAL
This change introduces the use of SSHClient and simple library that uses golang ssh client to execute commands remotely. I have tested prep-node remotely, but nothing else. Will be doing more refactoring as more testing is performed.
roopakparikh
force-pushed
the
private/rparikh/ssh
branch
from
e012593 to
90acb7e
Compare
abhimanyubabbar
approved these changes
Oct 28, 2020
Contributor
abhimanyubabbar
left a comment
abhimanyubabbar
left a comment
There was a problem hiding this comment.
Changes looks good to me 👍 
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the use of SSHClient and simple library
that uses golang ssh client to execute commands remotely.
I have tested prep-node remotely, but nothing else. Will be doing
more refactoring as more testing is performed.