Skip to content

Conversation

@devidask27
Copy link
Contributor

ISSUE(S):

https://platform9.atlassian.net/browse/INF-2864

SUMMARY

added one hidden flag to skip installer download step.

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

prep-node

TESTING DONE

Manual

Tested prep-node with and without --skip-installer-downloadflag
case one
prep-node --skip-installer-download, but installer is not present in pf9 dir
result --> failing with below logs

{"level":"debug","ts":"2023-08-03T12:00:49.9112Z","caller":"pmk/node.go:263","msg":"User skiped installer download"}
{"level":"debug","ts":"2023-08-03T12:00:49.9384Z","caller":"pmk/node.go:320","msg":"Ran command sudo \"bash\" \"-c\" \"chmod +x /root/pf9/installer.sh\""}
{"level":"debug","ts":"2023-08-03T12:00:49.9385Z","caller":"pmk/node.go:320","msg":"stdout:stderr:chmod: cannot access '/root/pf9/installer.sh': No such file or directory\n"}

case two
prep-node --skip-installer-download, installer is already copied in pf9 dir
result --> node onboarded successfully

case three
natural flow, prep-node without --skip-installer-download flag
result --> node onboarded successfully

Reviewers

/cc @sudhakarg @psarwate

@cruizen cruizen requested review from jayanth-tjvrr, srm6867 and vedantjoshi84 and removed request for sudhakarg July 24, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants