Skip to content

Conversation

@asizikov
Copy link

@asizikov asizikov commented Apr 26, 2022

Breaking change:

ColorSerializer removed, because it depends on System.Drawing APIs that were removed from netstandard

@asizikov asizikov force-pushed the feature/netstandard branch from d2f9136 to 3ad479f Compare April 26, 2022 19:32
@tumtumtum
Copy link
Member

Sorry, I didn't read all the changes but what replaces src/Platform.Xml.Serialization/Attributes/XmlSerializationAttribute.cs etc in netstandard?

@asizikov
Copy link
Author

huh, good question. Yeah, they were auto-removed as unused classed. My bad, I'll review and revert that

@asizikov
Copy link
Author

@tumtumtum ok, I compared with the original version, and I can confirm that deleted attributes and type serializers files where not in use. /Attributes and /TypeSerializers dirs were not a part of Platform.Xml.Serialization solution. Same attributes are still in the solution, but they are placed according to "one class per file" rule.

For example XmlCDataAttribute is still there: https://github.com/asizikov/Platform/blob/feature/netstandard/src/Platform.Xml.Serialization/XmlCDataAttribute.cs

@asizikov
Copy link
Author

asizikov commented Jul 1, 2022

@tumtumtum did you have time to have another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants