async-http-client 3.0.0 (was 2.12.3)

[scala-steward]

About this PR

📦 Updates org.asynchttpclient:async-http-client from 2.12.3 to 3.0.0 ⚠

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.asynchttpclient", artifactId = "async-http-client" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.asynchttpclient", artifactId = "async-http-client" }
}]

^{labels: library-update, early-semver-major, semver-spec-major, commit-count:1}

[mkurz]

So... async-http-client v3 drops netty-reactive-streams, so this needs some work probably. e.g the shading will not be necessary anymore.
See comments in

• Correctly shade netty-reactive-streams #863

Related

• netty-reactive-streams 3.0.2 (was 2.0.12) #915

[Nezisi]

As a heads up @mkurz ...

AHC 3

• drops OAuth ( Drop OAuth1 Support AsyncHttpClient/async-http-client#1902 )
• drops Stream Handling ( Prepare for v3.0.0 AsyncHttpClient/async-http-client#1843 | How to migrate StreamedAsyncHandler in v3? AsyncHttpClient/async-http-client#1925 )
• migrates to Duration
  • [Question] Using java.time.Duration for timeouts and ttls AsyncHttpClient/async-http-client#1861
  • Changed connectTimeout's type to java.time.Duration AsyncHttpClient/async-http-client#1862
  • Changed requestTimeout's type to java.time.Duration AsyncHttpClient/async-http-client#1864
  • Changed readTimeout's type to java.time.Duration AsyncHttpClient/async-http-client#1865
  • Changed some other fields to java.time.Duration AsyncHttpClient/async-http-client#1866

Not an huge effort to port it if one uses the good old battle axe... But would mean dropping OAuth 1 / Streaming Future (unless one invests into an alternative stream handler)

[mkurz]

Side note: we can remove the scala pin afterwards:

play-ws/.github/scala-steward.conf

Lines 5 to 7 in 152c072

	pullRequests.grouping = [
	{ name = "patches", "title" = "Patch updates", "filter" = [{"version" = "patch"}] }
	]

[mkurz]

@Nezisi would you be interested in providing a PR to upgrade async-http-client to version 3 in this repo?