This repository was archived by the owner on Jun 1, 2022. It is now read-only.
[RFC] InputCEC activateSource on receivedInput #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My long term goal can be described as two separate features: 1. When Plex Media Player activates the screensaver, all CEC devices (Receiver/Soundbar, Projector/TV) power off 2. When Plex Media Player deactivates the screensaver (eg, by keyboard or remote input) all CEC devices power on and the inputs are changed if necessary This pull request is a first attempt at accomplishing device power on. My first goal here was to connect it to the PowerComponent screenSaverEnabled and screenSaverDisabled signals, but the comments in PowerComenent.h seem to indicate that those are deprecated and not funcitonal. Without having those to rely on, I have instead connected the activateSource method to keyboard input. This is suboptimal because we're flooding the CEC devices with unnecessary signals on every keystroke. I wanted to get the discussion rolling on how to implement this. Is there any upcoming replacement for the screensaver signals that I could connect this to instead? I look forward to your feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1054 but moved to another branch (I don't see a way to change the head branch on a Pull request other than creating a new one).
My long term goal can be described as two separate features:
Projector/TV) power off
devices power on and the inputs are changed if necessary
This pull request is a first attempt at accomplishing device power on.
My first goal here was to connect it to the PowerComponent screenSaverEnabled and
screenSaverDisabled signals, but the comments in PowerComenent.h seem to indicate that those are
deprecated and not funcitonal.
Without having those to rely on, I have instead connected the activateSource method to keyboard
input. This is suboptimal because we're flooding the CEC devices with unnecessary signals on
every keystroke.
I wanted to get the discussion rolling on how to implement this. Is there any upcoming replacement
for the screensaver signals that I could connect this to instead?
I look forward to your feedback.