Add support for parsing async iterable<T> type
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
plinss
reviewed
Mar 25, 2024
widlparser/productions.py
Outdated
| self.async_iterable[0].define_markup(generator) | ||
| self.async_iterable[1].define_markup(generator) | ||
| generator.add_text(self._open_type) | ||
| self.type.define_markup(generator) |
Owner
There was a problem hiding this comment.
Suggested change
| self.type.define_markup(generator) | |
| generator.add_type(self.type) |
Contributor
Author
There was a problem hiding this comment.
Done. I had copied this from the self.record branch.
Owner
|
Thanks for the PR, can you also update the |
Owner
|
This has been merged, not sure why GH isn't marking it as such |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref whatwg/webidl#1397
DO NOT LAND UNTIL SPEC CHANGE IS LANDED