Fix duplicate getUploadedFileNameForStorageUsing callbacks in Colors.php

[sandervanhooft]

Bug

In app/Filament/Pages/Colors.php, both the logo and favicon FileUpload fields have duplicate getUploadedFileNameForStorageUsing() callbacks chained on them. Since PHP method chaining means the last call wins, this causes:

Logo field

The second (incorrect) callback overrides the first and returns storage_path("app/public/...") — an absolute server path like /var/www/html/storage/app/public/logo-foo.png — instead of a relative filename. This gets stored as the filename, resulting in broken image URLs.

Favicon field

The first (incorrect) callback returns storage_path("app/public/favicon.png"), but is overridden by the second (correct) one returning "favicon.png". The broken callback is dead code but misleading.

Fix

Remove the duplicate getUploadedFileNameForStorageUsing() callbacks, keeping only the correct ones:

• Logo: logo-{originalname} (relative filename)
• Favicon: favicon.png (relative filename)

Before (logo example)

->getUploadedFileNameForStorageUsing(
    function (TemporaryUploadedFile $file): string {
        return (string)str($file->getClientOriginalName())->prepend('logo-');
    }
)
->getUploadedFileNameForStorageUsing(  // ❌ overrides the above
    function ($record) {
        return storage_path('app/public/' . app(ColorSettings::class)->logo);
    }
)

After

->getUploadedFileNameForStorageUsing(
    function (TemporaryUploadedFile $file): string {
        return (string)str($file->getClientOriginalName())->prepend('logo-');
    }
)