Skip to content

Get search on dynamic groups working (temp hack) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 4 commits into from
Nov 18, 2025
Merged

Get search on dynamic groups working (temp hack) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c0506c
Get search on dynamic groups working (temp hack)
stonebuzz Nov 18, 2025
95b2e19
adapt changelog
stonebuzz Nov 18, 2025
550d928
fix CS
stonebuzz Nov 18, 2025
768345c
fix
stonebuzz Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASED]

### Fixed

- Fix dynamic group submit bouton

## [1.1.1] - 2025-11-13

### Fixed
Expand Down
7 changes: 7 additions & 0 deletions inc/computergroupdynamic.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
* -------------------------------------------------------------------------
*/

use function Safe\ob_start;
use function Safe\ob_get_clean;
use function Safe\preg_match;
use function Safe\preg_replace;
use function Safe\preg_split;
Expand Down Expand Up @@ -228,7 +230,12 @@ private static function showForItem(PluginDatabaseinventoryComputerGroup $comput
$p['actionname'] = 'save';
$p['actionvalue'] = _sx('button', 'Save');
$p['showbookmark'] = false;

//hack because submit button is not a submit... See https://github.com/glpi-project/glpi/pull/20731
ob_start();
Search::showGenericSearch(Computer::getType(), $p);
$generic_search = ob_get_clean();
echo preg_replace('/type="button" name="save"/', 'type="submit" name="save"', $generic_search);

//display result from search
if (!$firsttime) {
Expand Down