Skip to content

Conversation

@eduardomozart
Copy link

The correct string is 'Observer' instead of 'Watcher'.

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does: The correct string is 'Observer' instead of 'Watcher' in GLPI translation files (*.po).

Screenshots (if appropriate):

As can be seen in screenshot below, the word "Watcher" and "Watcher group" isn't being translated to PT-BR.

image

The correct string is 'Observer' instead of 'Watcher'.
@Rom1-B Rom1-B requested review from Rom1-B and stonebuzz January 8, 2026 10:01
@stonebuzz
Copy link

indeed, 'Watcher' no longer exist from GLPI locales

Copy link

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These texts can be plural, so you should use this syntax:

_n('Observer', 'Observers', 1)
_n('Observer group', 'Observer groups', 1)

@eduardomozart
Copy link
Author

These texts can be plural, so you should use this syntax:

_n('Observer', 'Observers', 1)
_n('Observer group', 'Observer groups', 1)

Changes has been done and tested, working as expected.

@Rom1-B Rom1-B self-requested a review January 8, 2026 11:29
@Rom1-B Rom1-B merged commit dcde078 into pluginsGLPI:main Jan 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants