remove spinstreak arg for event #245
Conversation
Summary by OctaneNew ContractsNo new contracts were added. Updated Contracts
🔗 Commit Hash: be314fd |
There was a problem hiding this comment.
Pull request overview
This PR removes the currentStreak parameter from the SpinCompleted event to simplify the event signature. The change reduces event data emissions while the streak information remains accessible through the contract's state.
Changes:
- Removed
currentStreakparameter from theSpinCompletedevent declaration - Updated event emission to exclude the streak value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| event SpinCompleted( | ||
| address indexed walletAddress, string rewardCategory, uint256 rewardAmount, uint256 currentStreak | ||
| ); | ||
| event SpinCompleted(address indexed walletAddress, string rewardCategory, uint256 rewardAmount); |
There was a problem hiding this comment.
Removing the currentStreak parameter from the SpinCompleted event is a breaking change that will affect any off-chain systems (indexers, analytics dashboards, frontend applications) currently listening to this event. While the currentStreak value is still computed and stored in userDataStorage.streakCount (line 253), it's no longer emitted in the event. Consider whether off-chain consumers need this data or if they can retrieve it through other means (e.g., by querying the userData mapping).
Overview
Detailed findings
|
What's new in this PR?
In bullet point format, please describe what's new in this PR.
Why?
What problem does this solve?
Why is this important?
What's the context?