[feature] Add bsc configs #2

ungaro · 2025-09-23T14:06:42Z

# compile
pnpm install && pnpm compile

# deploy PlumeOFT on BSC (Plume already done)
npx hardhat lz:deploy --network bsc-mainnet --tags PlumeOFT

# wire both directions using the unified config
npx hardhat lz:oapp:wire --oapp-config layerzero.plume.plumephoenix-bsc.config.ts

# verify active settings
npx hardhat lz:oapp:config:get --oapp-config layerzero.plume.plumephoenix-bsc.config.ts
npx hardhat lz:oapp:config:get:executor --oapp-config layerzero.plume.plumephoenix-bsc.config.ts

# smoke send (replace with actual addresses/EIDs)
npx hardhat lz:oft:send \
  --network plumephoenix-mainnet \
  --contract PlumeOFT \
  --to <BSC_PlumeOFT_Proxy> \
  --toEid <BSC_EID> \
  --amount 100000000000000   # 0.0001 PLUME

Copilot

Pull Request Overview

This PR adds BSC (Binance Smart Chain) configuration to the LayerZero project, enabling bidirectional communication between PlumePhoenix and BSC networks for the PlumeOFT token.

Key changes:

Creates new LayerZero configuration file for PlumePhoenix-BSC pathway
Adds BSC mainnet network configuration to Hardhat config
Sets up bidirectional token transfer capabilities with enforced options

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
layerzero.plume.plumephoenix-bsc.config.ts	New LayerZero configuration defining bidirectional pathway between PlumePhoenix and BSC with enforced gas options
hardhat.config.ts	Adds BSC mainnet network configuration with endpoint ID and RPC URL

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-23T14:07:01Z

layerzero.plume.plumephoenix-bsc.config.ts

+
+

[nitpick] Remove the trailing empty lines at the end of the file to maintain consistent formatting.

Suggested change

ungaro · 2025-09-23T14:38:48Z

ethereum <-> bsc

Deploy PlumeOFT on BSC:
npx hardhat lz:deploy --network bsc-mainnet --tags PlumeOFT
Wire:
npx hardhat lz:oapp:wire --oapp-config layerzero.plume.ethereum-bsc.config.ts
Verify:
npx hardhat lz:oapp:config:get --oapp-config layerzero.plume.ethereum-bsc.config.ts
npx hardhat lz:oapp:config:get:executor --oapp-config layerzero.plume.ethereum-bsc.config.ts
Smoke send:
npx hardhat lz:oft:send --network ethereum-mainnet --contract PlumeOFT --to <BSC_PlumeOFT_Proxy> --toEid <BSC_EID> --amount 100000000000000
npx hardhat lz:oft:send --network bsc-mainnet --contract PlumeOFT --to <ETH_PlumeOFT_Address> --toEid <ETH_EID> --amount 100000000000000

Copilot

Pull Request Overview

Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

package.json:1

The removal of @openzeppelin/hardhat-upgrades dependency should be documented in the PR description or commit message to explain why this functionality is no longer needed.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T23:03:53Z

hardhat.config.ts

        'Could not find MNEMONIC or PRIVATE_KEY environment variables. It will not be possible to execute transactions in your example.'
    )
 }
+console.log("RPC_URL_BSC_MAINNET",process.env.RPC_URL_BSC_MAINNET);


Debug console.log statement should be removed before merging to production. This appears to be leftover debugging code.

Suggested change

console.log("RPC_URL_BSC_MAINNET",process.env.RPC_URL_BSC_MAINNET);

Copilot · 2025-09-26T23:03:54Z

hardhat.config.ts

 import 'dotenv/config'

-import '@openzeppelin/hardhat-upgrades'
+//import '@openzeppelin/hardhat-upgrades'


Commented-out import should be removed instead of being left as a comment. If the import is no longer needed, delete the line entirely.

Suggested change

//import '@openzeppelin/hardhat-upgrades'

Copilot · 2025-09-26T23:03:54Z

package.json

+    "@types/chai": "4.3.7",
    "@types/mocha": "^10.0.6",
    "@types/node": "~18.18.14",
-    "chai": "^4.4.1",
+    "chai": "4.3.7",


Downgrading chai and @types/chai from newer versions (^4.4.1 and ^4.3.11) to 4.3.7 should be explained. Version downgrades can introduce compatibility issues or remove bug fixes.

Copilot

Pull Request Overview

Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T17:01:07Z

package.json

    "@openzeppelin/contracts": "^5.0.2",
    "@openzeppelin/contracts-upgradeable": "^5.0.2",
-    "@openzeppelin/hardhat-upgrades": "^1.28.0",
+


Empty line after removing '@openzeppelin/hardhat-upgrades' package should be cleaned up to maintain consistent formatting.

Suggested change

Copilot · 2025-10-06T17:01:08Z

hardhat.config.ts

 import '@nomiclabs/hardhat-ethers'
 import '@layerzerolabs/toolbox-hardhat'
-
+const { vars } = require("hardhat/config");


The imported 'vars' variable is declared but never used in the code. Consider removing this unused import.

Suggested change

const { vars } = require("hardhat/config");

Copilot · 2025-10-06T17:01:08Z

layerzero.plume.ethereum-bsc.config.ts

+            [['LayerZero Labs', 'Google Cloud'], []],
+            [20, 15],
+            [ENFORCED, ENFORCED],
+        ],  


Trailing whitespace should be removed from the end of line 35.

Suggested change

],

],

Copilot

Pull Request Overview

Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

hardhat.config.ts:1

[nitpick] Remove unnecessary blank lines in the plugins array configuration. This improves code consistency and readability.

// Get the environment configuration from .env file

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T21:08:46Z

hardhat.config.ts

+console.log("RPC_URL_BSC_MAINNET",process.env.RPC_URL_BSC_MAINNET);
+console.log("RPC_URL_ETH_MAINNET",process.env.RPC_URL_ETH_MAINNET);


Remove console.log statements from production code. These debug statements should not be committed to the repository as they can expose sensitive configuration details and clutter the console output.

Suggested change

console.log("RPC_URL_BSC_MAINNET",process.env.RPC_URL_BSC_MAINNET);

console.log("RPC_URL_ETH_MAINNET",process.env.RPC_URL_ETH_MAINNET);

Copilot · 2025-10-06T21:08:46Z

hardhat.config.ts

+            eid: EndpointId.BSC_V2_MAINNET,
+            url: 'http://127.0.0.1:8545',
+            chainId: 56,
+            accounts: [process.env.PRIVATE_KEY || '0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'],


The commented code contains a hardcoded private key that appears to be a well-known test key. Even in commented code, this should be removed to avoid potential security risks.

Suggested change

accounts: [process.env.PRIVATE_KEY || '0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'],

accounts: [process.env.PRIVATE_KEY],

Copilot · 2025-10-06T21:08:47Z

hardhat.config.ts

 import '@nomiclabs/hardhat-ethers'
 import '@layerzerolabs/toolbox-hardhat'
-
+const { vars } = require("hardhat/config");


Use consistent import syntax. This line uses CommonJS require() while the rest of the file uses ES6 imports. Consider changing to: import { vars } from 'hardhat/config';

Suggested change

const { vars } = require("hardhat/config");

import { vars } from 'hardhat/config';

add bsc configs

58e3a62

Copilot AI review requested due to automatic review settings September 23, 2025 14:06

Copilot AI reviewed Sep 23, 2025

View reviewed changes

add bsc <-> ethereum

237699c

deploy plumeoft

43f0087

Copilot AI review requested due to automatic review settings September 26, 2025 23:03

Copilot AI reviewed Sep 26, 2025

View reviewed changes

ungaro added 2 commits October 6, 2025 12:49

update bsc-eth dvns

9284d6f

update gas

0f96691

Copilot AI review requested due to automatic review settings October 6, 2025 17:00

Copilot AI reviewed Oct 6, 2025

View reviewed changes

ungaro added 2 commits October 6, 2025 13:23

update hardhat config

239cd15

update config

321412e

Copilot AI review requested due to automatic review settings October 6, 2025 21:08

Copilot AI reviewed Oct 6, 2025

View reviewed changes

		console.log("RPC_URL_BSC_MAINNET",process.env.RPC_URL_BSC_MAINNET);
		console.log("RPC_URL_ETH_MAINNET",process.env.RPC_URL_ETH_MAINNET);

	accounts: [process.env.PRIVATE_KEY \|\| '0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'],
	accounts: [process.env.PRIVATE_KEY],

	const { vars } = require("hardhat/config");
	import { vars } from 'hardhat/config';

[feature] Add bsc configs #2

Are you sure you want to change the base?

[feature] Add bsc configs #2

Uh oh!

Conversation

ungaro commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

ungaro commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants