Skip to content

Comments

More chart fixups#3236

Open
michaeljguarino wants to merge 2 commits intomasterfrom
more-chart-fixes
Open

More chart fixups#3236
michaeljguarino wants to merge 2 commits intomasterfrom
more-chart-fixes

Conversation

@michaeljguarino
Copy link
Member

Add structured config for:

  1. license key
  2. admin email configs
  3. auto-inferring git server from airgapped

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

Plural Flow: console

@michaeljguarino michaeljguarino requested a review from a team February 19, 2026 18:13
@michaeljguarino michaeljguarino added the enhancement New feature or request label Feb 19, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 19, 2026

Greptile Summary

Added structured configuration for license keys, admin emails, and automatic git server setup in airgapped deployments, plus new sentinel default configuration options for integration tests.

  • Added licenseKey and adminEmails configuration to Helm values and environment variables for airgapped installations
  • Configured git-server to auto-deploy when airgap mode is enabled (not just when explicitly enabled via gitServer.enabled)
  • Added default configuration block to Sentinel integration tests for controlling namespace/resource labels, annotations, and container registry
  • Implemented hackney connection pool for AI providers (Anthropic and OpenAI) to manage concurrent connections efficiently
  • Updated GraphQL schema, Go CRDs, and controller logic to support the new sentinel default configuration

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are well-structured configuration additions with proper schema definitions, consistent implementations across GraphQL/Go/Elixir layers, and no breaking changes to existing functionality
  • No files require special attention

Important Files Changed

Filename Overview
charts/console/templates/git-server.yaml Enabled git-server when airgap mode is enabled, not just when explicitly enabled
charts/console/templates/secrets.yaml Added license key and admin emails environment variables for airgapped installations
charts/console/values.yaml Added configuration options for licenseKey and adminEmails
lib/console/schema/sentinel.ex Added default configuration embedded schema for integration test defaults (namespace labels, resource annotations, etc.)
go/controller/api/v1alpha1/sentinel_types.go Added SentinelCheckIntegrationTestDefault struct with namespace/resource labels and annotations
go/controller/internal/controller/sentinel_controller.go Added buildIntegrationTestDefaultAttributes function to marshal default configuration to console attributes
lib/console/application.ex Added hackney connection pool for AI providers with max 100 connections
lib/console/ai/provider/anthropic.ex Configured Anthropic provider to use ai_pool hackney connection pool
lib/console/ai/provider/openai.ex Configured OpenAI provider to use ai_pool hackney connection pool

Last reviewed commit: 4088e61

@michaeljguarino
Copy link
Member Author

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile


defp default_changeset(model, attrs) do
model
|> cast(attrs, ~w(ingore namespace_labels namespace_annotations registry resource_annotations resource_labels)a)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: ingore should be ignore

Suggested change
|> cast(attrs, ~w(ingore namespace_labels namespace_annotations registry resource_annotations resource_labels)a)
|> cast(attrs, ~w(ignore namespace_labels namespace_annotations registry resource_annotations resource_labels)a)

@michaeljguarino michaeljguarino force-pushed the more-chart-fixes branch 3 times, most recently from 249ad07 to 4088e61 Compare February 19, 2026 22:51
@michaeljguarino
Copy link
Member Author

@greptileai

@michaeljguarino michaeljguarino force-pushed the more-chart-fixes branch 7 times, most recently from 4b25798 to 5a758a9 Compare February 20, 2026 23:29
Add structured config for:

1. license key
2. admin email configs
3. auto-inferring git server from airgapped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants