fix: restore SetAccessor for proper getter/setter functionality#229
Closed
jacobsologub wants to merge 0 commit intopmed:masterfrom
Closed
fix: restore SetAccessor for proper getter/setter functionality#229jacobsologub wants to merge 0 commit intopmed:masterfrom
jacobsologub wants to merge 0 commit intopmed:masterfrom
Conversation
jacobsologub
force-pushed
the
fix/getter-setter-issue-226
branch
from
2319567 to
96a44bf
Compare
jacobsologub
force-pushed
the
fix/getter-setter-issue-226
branch
from
96a44bf to
f08867e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the use of SetNativeDataProperty back to SetAccessor to fix getter/setter callbacks not being triggered properly.
SetNativeDataProperty creates pseudo-data properties that don't properly handle setter callbacks, especially on prototype chains. SetAccessor creates true accessor properties that work as expected.
Fixes #226