perf: cache sorted layer indices in pub-sub #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nyan-left thanks Did you make this change because you analysed the performance in a real app? |
Contributor
Author
|
Profiled some rerenders with dev tools, noticed that the sorts are happening needlessly. |
Contributor
|
Did you confirm that there's a performance improvement, especially for introducing the "Set"? Since arrays vs set performance mostly only matters for really large entries, in my experience, and I'd rather only introduce complexity for a verified performance gain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every property read (e.g.
backgroundColor) was sorting the layer list to find the winning value.With 150 panels × ~20 properties = 3000 sorts.
O(N * P)Solution
Sort once, cache the result. Only re-sort when layers actually change.
O(1)