This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Fix for different RSA Encryption in .NET 4.7 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello Lafe, This is a great submission and we thank you for it. We looked at this with the team and need to make an assessment if it affects anything in the PnP-Core library, especially if we need to plan some work on our nugget packaging. We will look at this further as soon as we get to it. Thanks! |
Author
|
@SharePointRadi Any news regarding this PR? |
Author
|
@SharePointRadi @VesaJuvonen Do you have any update regarding this PR? |
- RSACngProxy can be extended in the future to hold a copy of the key, if necessary
|
Facing the same issue, could really use this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with .NET 4.7 the
GetAsymmetricAlgorithmfunction of aX509AsymmetricSecurityKeyobject returns anAsymmetricAlgorithmof typeRSACnginstead of the previousRSACryptoServiceProvider. Unfortunately, theRSACryptoServiceProviderwas hardcoded and therefore, the library breaks on .NET 4.7. This Pull Requests adds compatibility for .NET 4.7 by adding a newSignatureProviderforRSACngand a Factory that creates the correctSignatureProviderbased on the encounteredAsymmetricAlgorithm.The .NET version of the project has been raised to .NET 4.6 in order to use the
RSACngobject, which has been introduced with .NET 4.6. However, the change is behind a conditional compilation flag "NET46", so it is still possible to build the library for .NET 4.5.