Unquote Sec-CH-UA-Platform and Sec-CH-UA-Platform-Version

[cbeckr]

Since clients provide these headers in quoted form, the related logic is off in real-world use.

References:

• https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform
• https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform-Version

[timhwang21]

I ran into this issue too. I believe we also need to unquote 'Sec-CH-UA-Model', which is also wrapped, at least on MacOS Chrome.

[opti]

FYI, these kind of changes will be overwritten on the first fixtures sync from the upstream: fixtures are not updated manually. There is bundle exec rake update_fixtures specifically for that:

device_detector/Rakefile

Lines 69 to 88 in e68ee76

	desc 'update fixtures from piwik project'
	task :update_fixtures do
	top = File.expand_path(__dir__)
	get_latest_piwik_checkout
	fixture_mappings = [
	{ target_path: "#{top}/spec/fixtures/detector", source_path: 'Tests/fixtures/*.yml' },
	{ target_path: "#{top}/spec/fixtures/client",
	source_path: 'Tests/Parser/Client/fixtures/*.yml' },
	{ target_path: "#{top}/spec/fixtures/parser", source_path: 'Tests/Parser/fixtures/*.yml' },
	{ target_path: "#{top}/spec/fixtures/device",
	source_path: 'Tests/Parser/Device/fixtures/*.yml' }
	]
	fixture_mappings.each do |mapping|
	source_path = mapping.fetch(:source_path)
	target_path = mapping.fetch(:target_path)
	system "cp -R #{PIWIK_CHECKOUT_LOCATION}/#{source_path} #{target_path}"
	end
	end

I would suggest to add a dedicated test for the unquote functionality outside of the existing fixtures. Some examples can be found in here: https://github.com/podigee/device_detector/tree/develop/spec/device_detector

[liviuconcioiu]

Hi everyone! If you think there's something that should be changed upstream, it will be much better to open an issue there.