Capitalize brequelpassivesubtrees #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know the dat files are lowercase now but given every other type is capitalized it seems good to stick with that. This impacts code generation for languages that have style or rules for variable names or struct member names. e.g. for python variables/methods or rust struct member names I can programmatically turn BrequelPassiveSubTrees into brequel_passive_sub_trees, but can't without the capitalization. I understand this is technically a breaking change but given upstream's clear case-insensitivity it seems like a relatively minor one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the dat files are lowercase now but given every other type is
capitalized it seems good to stick with that.
This impacts code generation for languages that have style or rules for
variable names or struct member names.
e.g. for python variables/methods or rust struct member names I can
programmatically turn BrequelPassiveSubTrees into
brequel_passive_sub_trees, but can't without the capitalization.
I understand this is technically a breaking change but given upstream's
clear case-insensitivity it seems like a relatively minor one.