fix(compiler): sanitize node IDs for valid C macro generation#35
Merged
MadhurKumar004 merged 2 commits intopointblank-club:mainfrom Feb 7, 2026
Merged
Conversation
Introduces _sanitize_identifier to ensure node IDs are valid C tokens. Replaces non-alphanumeric characters and handles leading digits with underscores to prevent compilation errors in generated headers. Updates EdgeBackendCCode.generate to use sanitized IDs for EF_NODE_ macros.
Adds test_c_identifier_sanitization to TestModuleAttributes class in tests/test_parser_extended.py. Covers hyphen/dot replacement, leading digits, and special characters to ensure robust macro generation.
Collaborator
|
Good work, thanks for the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fixes compilation errors in the C backend caused by node identifiers containing invalid characters like hyphens, dots, or spaces.
The issue: Node IDs often include characters that are illegal in C macros (e.g., "conv-layer.1"). The generator previously used these IDs directly, resulting in invalid C code like "#define EF_NODE_CONV-LAYER.1".
The fix:
Testing: Added unit tests in tests/test_parser_extended.py to verify:
Resolves: #15