Merged
Conversation
bryanchriswhite
added
p2p
10 tasks
bryanchriswhite
force-pushed
the
refactor/p2p-submodules
branch
from
0992775 to
e11a55a
Compare
bryanchriswhite
added
push-image
bryanchriswhite
force-pushed
the
refactor/p2p-submodules
branch
5 times, most recently
from
3f0dd91 to
44a2750
Compare
bryanchriswhite
force-pushed
the
refactor/p2p-submodules
branch
from
44a2750 to
8bfecbf
Compare
bryanchriswhite
force-pushed
the
refactor/p2p-submodules
branch
from
8bfecbf to
6f87169
Compare
Olshansk
approved these changes
Jul 12, 2023
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
@bryanchriswhite Don't really have any good / constructive feedback on this. As long as things work, superficially this looks pretty good!
| mockModulesRegistry.EXPECT().GetModule(current_height_provider.ModuleName).Return(nil, runtime.ErrModuleNotRegistered(current_height_provider.ModuleName)).AnyTimes() | ||
| mockBus.EXPECT().GetModulesRegistry().Return(mockModulesRegistry).AnyTimes() | ||
| modulesRegistry := runtime.NewModulesRegistry() | ||
| mockBus.EXPECT(). |
Collaborator
There was a problem hiding this comment.
I'm 👁️ ing patterns emerge!
20 tasks
- comment updates - one-lining error checks Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Reviewer
This PR may be more digestible / reviewable on a commit-by-commit basis. Commits are organized logically and any given line is only modified in a single commit, with few exceptions*.
*(In the interest of preserving the git-time-continuum 👮🚨, this applies in batches of commits between comments or reviews by humans, only once "in review")
Description
Refactor P2P module dependencies as submodules, ultimately to support usage P2P module usage in the CLI.
Issue
Related:
Dependant(s):
peer connectionssubcommand #801peer listsubcommand #892Type of change
Please mark the relevant option(s):
List of changes
CurrentHeightProviderto a submodule interface typeconsensusCurrentHeightProviderimplementationRouterinterface to a submodule interface typebackgroundRouterimplementation to submodulerainTreeRouterimplementation to submoduleTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)