[Chore][WIP] Adds assertions to rollback error path test#944
Closed
[Chore][WIP] Adds assertions to rollback error path test#944
Conversation
20 tasks
reviewpad
bot
added
small
dylanlott
force-pushed
the
persistence/rollback-error-path
branch
from
b6c8068 to
8faf2b2
Compare
dylanlott
changed the title
dylanlott
force-pushed
the
persistence/rollback-error-path
branch
from
935296e to
6d075c5
Compare
Olshansk
requested changes
Aug 1, 2023
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
Just a couple minor NITS, but why is it a draft?
| tmpdir := t.TempDir() | ||
| cfg := newTestDefaultConfig(t, dbUrl) | ||
| cfg.Persistence.TreesStoreDir = tmpdir | ||
| pmod := newTestPersistenceModule(t, cfg) |
Collaborator
There was a problem hiding this comment.
Suggested change
| pmod := newTestPersistenceModule(t, cfg) | |
| pMod := newTestPersistenceModule(t, cfg) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR captures the update to the rollback error path, with regard to the create and release lifecycle for a
RWContextin a pocket node.Issue
Related to #861
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)