ENH: Dark theme with light Stanford logo and default to browser preference#12
Draft
effigies wants to merge 4 commits intopoldracklab:mainfrom
Draft
ENH: Dark theme with light Stanford logo and default to browser preference#12effigies wants to merge 4 commits intopoldracklab:mainfrom
effigies wants to merge 4 commits intopoldracklab:mainfrom
Conversation
effigies
changed the title
Contributor
Author
|
Converted to draft, as sharing this with Quarto devs led one to point out that dark mode can produce flashes on load, which might trigger epilepsy: quarto-dev/quarto-cli#2588 (reply in thread) Will probably try to play around with it more sooner or later. I really don't like light themes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated a white logo from Stanford branding and cropped it to match the current logo.
I don't really understand why this isn't working. Chrome continues to show the dark logo, while Firefox only shows the light logo. Will probably need Javascript to actually make this work, which seems bad when HTML supports this.
Marking this as a draft in case anybody wants to figure this out. Will mark it ready to review if/when I get around to doing this.