-
Notifications
You must be signed in to change notification settings - Fork 78
FIX endpoints to PAH #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/product-ia
Are you sure you want to change the base?
FIX endpoints to PAH #1337
Conversation
…nd chain ID - Changed RPC URL from 'https://testnet-passet-hub-eth-rpc.polkadot.io' to 'https://services.polkadothub-rpc.com/testnet' across multiple files. - Updated chain ID from 420420422 to 420420417 in relevant configurations and documentation. - Adjusted deployment outputs and examples to reflect the new network settings. - Removed outdated faucet GIF and updated references in documentation for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated style guide suggestions (1-1 of 1)
| @@ -1,6 +1,6 @@ | |||
| <div id="termynal" data-termynal markdown> | |||
| <span data-ty="input">npx hardhat ignition deploy ignition/modules/Storage.ts --network polkadotTestnet</span> | |||
| <span data-ty>✔ Confirm deploy to network polkadotTestnet (420420420)? … yes</span> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a search for 420420420, so I just wanted to flag these two instances that were left to see if they were missed or this is intentional:
.snippets/code/smart-contracts/cookbook/smart-contracts/deploy-nft/nft-hardhat/deploy-output.html
smart-contracts/cookbook/dapps/zero-to-hero.md
| }, | ||
| networks: { | ||
| polkadotTestnet: { | ||
| url: 'https://testnet-passet-hub-eth-rpc.polkadot.io', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Searched for this and it's still in quite a few places, some of the files were hidden pages, but a few were not
| networks: { | ||
| polkadotTestnet: { | ||
| url: 'https://testnet-passet-hub-eth-rpc.polkadot.io', | ||
| chainId: 420420422, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also searched this, it's showing up in the connect-to-metamask.js script
📝 Description
This pull request updates all references to the Polkadot Hub TestNet RPC endpoint, chain ID, block explorer, and faucet URLs across code samples and documentation. The changes ensure consistency and accuracy by switching to the latest official endpoints and identifiers. This includes updates in Hardhat, ethers.js, viem, web3.js, web3.py, and wagmi code snippets, as well as related documentation.
Network configuration and endpoint updates:
Replaced all occurrences of the old RPC URL (
https://testnet-passet-hub-eth-rpc.polkadot.io) with the new official endpoint (https://services.polkadothub-rpc.com/testnet) in Hardhat config files, ethers.js, viem, web3.js, web3.py, and wagmi code samples. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27]Updated the Polkadot Hub TestNet chain ID from
420420422(and other outdated variants) to the correct value420420417across all code and documentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Documentation and explorer updates:
Changed block explorer references from BlockScout to Routescan and updated the explorer URL from
https://blockscout-passet-hub.parity-testnet.parity.io/tohttps://polkadot.testnet.routescan.io/. [1] [2]Updated faucet instructions and images to point to the new Polkadot Faucet URL (
https://faucet.polkadot.io/) and refreshed the example image. [1] [2]Sample output and instructional text updates:
These updates ensure that all developer resources and code samples are aligned with the current Polkadot Hub TestNet configuration, reducing confusion and improving the onboarding experience for developers.
🔍 Review Preference
Choose one:
🤖 AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.py✅ Checklist