[Feature/PE1-16] Implementation of the welcome page#11
[Feature/PE1-16] Implementation of the welcome page#11Sheldonsu28 wants to merge 4 commits intodevelopfrom
Conversation
…lender, rectangle overlay)
|
Scope of work: |
|
Looks like solid progress, thanks @Sheldonsu28! Given Frank's asset management branch is recently merged, would you mind syncing this branch with #7? Just run |
|
It appears to me that conflict of packages do exists; |
shoko-inori
left a comment
shoko-inori
left a comment
There was a problem hiding this comment.
Version conflict on installed packages needs to be resolved.
There was a problem hiding this comment.
Thanks for contributing! Just a few comments for us to think about. Please see below.
Some general notes about file naming
Regarding file naming, please read this section of the dart language docs: https://dart.dev/guides/language/effective-dart/style#do-name-libraries-and-source-files-using-lowercase_with_underscores.
In general, let's have a discussion on the convention above. According to the above document, we should name files using underscores rather than camel case. For example, maybe we should name a file calender_pic.dart instead of calenderPic.dart.
This is great work. However, it takes some time for all of us to get familiar with the Dart language. From this pull request, I think we are missing some convention checks around file names & image location. I will add that to my next tasks. Thank you for bringing this up!
| @@ -0,0 +1,56 @@ | |||
| import 'package:flutter/material.dart'; | |||
|
|
|||
| class BottomSquareWithButton extends StatelessWidget { | |||
There was a problem hiding this comment.
Thanks for your contribution! I was wondering if there's a better name for this widget. For example, it might be better to call it ButtonContainer.
| child: Image( | ||
| height: MediaQuery.of(context).size.height * 0.1, | ||
| width: MediaQuery.of(context).size.width * 0.8, | ||
| image: AssetImage(assetLocation), | ||
| fit: BoxFit.fitWidth), |
There was a problem hiding this comment.
This was mentioned on another pull request with @shoko-inori. @shoko-inori Did you find a solution to code this button rather than using an image?
| } | ||
|
|
||
| /// Sign up button for the welcome page, use the raised button. | ||
| class WelcomeButtons extends StatelessWidget { |
There was a problem hiding this comment.
Thanks for your contribution! I'm a bit confused about the naming of this widget. Seems like we are only having one button inside of it, but the name is plural. Would you mind explaining why It's called WelcomeButtons rather than WelcomeButton? 🤔
4 participants
This contains the implementation for the welcome page.