[:recycle:] Eliminate unneeded coupling with zipFile :coffin: #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardSto
approved these changes
Oct 17, 2022
fhd
pushed a commit
that referenced
this pull request
Nov 3, 2022
# ✍️ Description This code was the only one using the construction `zipFile.getContent`, which apparently disappeared a some point in time. It's been refactored to work as intended, getting the content of a single `ZipEntry`. Adds a tests which fails if the original content was used. ### 🏗️ Fixes PROD4POD-1940 This was found while doing #1219, so it's a blocker for that one. ## ℹ️ Other information Deep tests have not really been performed; they're mainly sanity tests. Rendering tests are not checked either. Better mocks would probably be needed for better tests. (Unrelated) coupling with `zipFile` has been eliminated from the function, since it's no longer needed. The function was returning a data structure which included it, not doing that does not seem to affect the outcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Again, this was found wanting for #1218. This coupling was probably not needed, so that all information for an entry occurs in the entry itself, and it does not need to be handled by the hosting zipFile. Since this is a Mock, we don't really need more than that.
ℹ️ Other information
Might include some tests, and additional spin-off of all ZipMockFile methods that create Entries.