List collectd plugins without rrd files enumeration #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 motives for the change: 1) Before the change CGP enumerated all rrd files to display graph.php or host.php and therefore broke if any single plugin directory lacks read permissions. 2) With active open_basedir PHP option recursive scan becomes really slow. Avoiding it gives huge speedup. For example on Core i5 and ~1300 rrd files: graph.php: 907 ms -> 31 ms host.php: 1372 ms -> 480 ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 motives for the change:
Before the change CGP enumerated all rrd files to display graph.php
or host.php and therefore broke if any single plugin directory lacks
read permissions.
With active
open_basedirPHP option recursive scan becomes reallyslow. Avoiding it gives huge speedup. For example on Core i5 and ~1300
rrd files:
graph.php: 907 ms -> 31 ms
host.php: 1372 ms -> 480 ms