Test of the inmemory db module #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few polishings coverage check
| db.listPictures(null, 'desc'), | ||
| arrayInOrder(initialData, [2, 3, 4, 1]), | ||
| 'It works in descending order.', | ||
| ); |
Contributor
There was a problem hiding this comment.
there's an alias for desc: z2a
| db.listPictures(null, 'rnd').length, | ||
| 4, | ||
| 'Returns the good number of values when random.', | ||
| ); |
Contributor
There was a problem hiding this comment.
there's an alias for rnd: random
| db.listPictures(null), | ||
| arrayInOrder(initialData, [4, 3, 2, 1]), | ||
| 'The default case works.', | ||
| ); |
Contributor
There was a problem hiding this comment.
this test above fits better together with the new test below because the default order is the same as new.
| for (const id of order) { | ||
| retval.push(arr.find((x) => { | ||
| return x.id === id; | ||
| })); |
Contributor
There was a problem hiding this comment.
just fyi, you don't need to change this here, but there's a shortcut for this:
retval.push(arr.find(x => x.id === id));
jacekkopecky
approved these changes
Apr 26, 2018
Contributor
jacekkopecky
left a comment
jacekkopecky
left a comment
There was a problem hiding this comment.
Good, thanks, we'll see in autumn what we can do with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have created tests for the file model-inmemory.js :
A few tests for the function listPictures that are testing every case of the switch.
Tests for the function deletePicture and its exceptions.
Tests for the function uploadPicture and its exception.
Added :
- Some tests to verify if files have been created and deleted.
- Some comments tnat were missing.
- Polishing.