Merged
Conversation
this was removed as a default linter from lintr in 3.2.0
nealrichardson
approved these changes
Dec 19, 2025
Collaborator
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Odd that the preview integration tests didn't fail before, but thanks for the clean fix!
Collaborator
Author
AFAICT from the logs on #484, the tests never actually ran on that PR. With the changes in posit-dev/with-connect#38 they run and fail. But fixed now. |
Collaborator
🤦 ah right, that. Thanks again! |
Contributor
|
Thanks @karawoo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Explicitly sets the pipe linter to
"auto"instead of the new default"|>". Also removes the cyclocomp linter line; it's no longer necessary as it's not a lintr default anymore since 3.2.0.Fixes #485
Approach
I chose to keep our existing magrittr pipe code instead of updating to the base pipe, mainly because we don't currently set a minimum R version in the DESCRIPTION. Using the base R pipe would require us to set the minimum to 4.1. This might be okay, and I don't feel too strongly either way, but this at least gets CI passing again.
Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?