Skip to content

Fix NoneType error when OS codename is None in dgoss environment #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianpittwood merged 2 commits into from
Feb 10, 2026
Merged

Fix NoneType error when OS codename is None in dgoss environment #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9f6f69
Fix NoneType error when OS codename is None in dgoss environment
ianpittwood Feb 6, 2026
39f5fe4
Merge branch 'main' into fix-dgoss-nonetype-codenames
ianpittwood Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions posit-bakery/posit_bakery/image/goss/dgoss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def image_environment(self) -> dict[str, str]:
if self.image_target.image_os:
e["IMAGE_OS"] = self.image_target.image_os.name
e["IMAGE_OS_NAME"] = self.image_target.image_os.buildOS.name
e["IMAGE_OS_CODENAME"] = self.image_target.image_os.buildOS.codename
e["IMAGE_OS_CODENAME"] = self.image_target.image_os.buildOS.codename or ""
e["IMAGE_OS_FAMILY"] = self.image_target.image_os.buildOS.family.value
e["IMAGE_OS_VERSION"] = self.image_target.image_os.buildOS.version
if self.image_target.build_args:
Expand Down Expand Up @@ -151,8 +151,9 @@ def command(self) -> list[str]:
for mount in self.volume_mounts:
cmd.extend(["-v", f"{mount[0]}:{mount[1]}"])
for env_var, value in self.image_environment.items():
env_value = re.sub(r"([\"\'\\$`!*?&#()|<>;\[\]{}\s])", r"\\\1", value)
cmd.extend(["-e", f"{env_var}={env_value}"])
if value is not None:
env_value = re.sub(r"([\"\'\\$`!*?&#()|<>;\[\]{}\s])", r"\\\1", value)
cmd.extend(["-e", f"{env_var}={env_value}"])
cmd.append("--init")
if self.runtime_options:
# TODO: We may want to validate this to ensure options are not duplicated.
Expand Down