Refactor image target metadata handling to allow multiple metadata attachments#358
Open
ianpittwood wants to merge 6 commits intomainfrom
Open
Refactor image target metadata handling to allow multiple metadata attachments#358ianpittwood wants to merge 6 commits intomainfrom
ianpittwood wants to merge 6 commits intomainfrom
Conversation
Test Results1 130 tests 1 130 ✅ 13m 27s ⏱️ Results for commit 817f96a. ♻️ This comment has been updated with latest results. |
Tests cover multiple platforms, duplicate platform handling (most recent wins), empty metadata error case, and single platform scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for platform mismatch fallback, explicit platform selection, and most recent metadata selection. Fix incorrect docstrings in existing ref tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for BuildMetadata.created_at property (from annotations, build provenance, and fallback to now) and platform property (from descriptor, build provenance environment, and None fallback). Add tests for MetadataFile.get_target_metadata_by_uid, __repr__, and FileNotFoundError handling. Remove unused __str__ method from MetadataFile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #340
ImageTargetto handle multiple metadata attachments at oncemetadata_filefield tobuild_metadatawhich takes alist[BuildMetadata]ci mergecommandimage_metadata.pyto improve handling of metadata objects and filesSettingsobject