-
Notifications
You must be signed in to change notification settings - Fork 135
Remove Copilot SDK and use Copilot Chat for completions #11163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmcphers
wants to merge
38
commits into
main
Choose a base branch
from
feature/copilot-sdk-begone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/copilot-sdk-begone
|
E2E Tests 🚀 |
Contributor
|
Lots of changes here so I'm going through some testing locally to see how authentication feels to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates Positron's dependence on the Copilot Language Server, and serves completions directly from an updated version of the GitHub Copilot Chat extension.
This solves a number of issues around authentication and feature parity with Copilot completions in VS Code.
Changes are also required to our Copilot Chat fork; see posit-dev/positron-copilot-chat#8.
Addresses #10491
Fixed: Auth state
Auth state is now derived from the built-in Accounts menu, instead of from the token that the LSP writes. This improves auth in remote SSH in particular, since the local authentication session can supply credentials to the chat and completion systems running on the the remote host.
#9811 - show correct state when signing out of copilot
#10365 - remote ssh auth again
#10317 - handle auth for remote ssh sessions
#8409 - also an issue for remote ssh auth
Fixed: Completion behavior
These issues are side effects of using the LSP, and should now be resolved.
#9301 - copilot completions emit a lot of console errors
#10564 - "trigger inline suggestion" command not supported
#11066 - copilot autocomplete does not work
Fixed: Working with a proxy
Now that all network requests are being made by the Copilot extension directly, VS Code's native network settings can be used to configure proxies and custom certificates.
https://docs.github.com/en/copilot/how-tos/configure-personal-settings/configure-network-settings
#8990 - certificate errors with sdk
#11015 - can't sign in to copilot
#8623 - issues signing in with a proxy
Partially fixed
#8775 - too many github sign ins. partially addressed; now copilot chat and completions share a sign in
Release Notes
New Features
Bug Fixes
QA Notes
Test tags:
@:assistant