Support rendering math expressions in notebooks #11167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10479
This PR adds partial support for rendering LaTeX in positron notebooks by utilizing KaTeX to render the HTML. Using KaTeX in our markdown rendering flow gets us most of the way there when it comes to supporting math expressions.
Because of our rendering pipeline which has an html parsing step, more complex expression support was not working. The root cause of this is
htmlParser.ts.parseHtml()not knowing how to parse the HTML string returned by KaTeX.We will need to move away from
htmlParserif we want better support for all markdown rendering. I am exploring some options and will update the original issue with my findings.Release Notes
New Features
Bug Fixes
QA Notes
@:positron-notebooks