test: Add E2E test for last selected deployment on init#3457
Open
zackverham wants to merge 9 commits intomainfrom
Open
test: Add E2E test for last selected deployment on init#3457zackverham wants to merge 9 commits intomainfrom
zackverham wants to merge 9 commits intomainfrom
Conversation
dotNomad
reviewed
Feb 5, 2026
| cy.expectInitialPublisherState(); | ||
|
|
||
| // Create a deployment (this also selects it) | ||
| cy.createPCSDeployment( |
Collaborator
There was a problem hiding this comment.
May have to clear up with deployment after the test runs to get other e2e tests passing
Ensure the static project deployments are cleaned up after the test to prevent affecting other E2E tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The propagateDeploymentSelection function was not awaiting the async saveSelectionState call, causing a race condition where the UI would update before the workspace state was persisted. This caused the E2E test for last selection initialization to fail because cy.reload() could happen before the selection was saved. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
I wonder if this will start to work after a rebase now that #3367 is merged |
…g tests Changes to deployments.cy.js: - Add cy.debugIframes() after reload for consistency with beforeEach - Wait for webview to fully initialize before checking for entrypoint-label - Use two-phase check: first wait for any UI element, then verify selection Changes to error-err-config.cy.js: - Add retryWithBackoff when searching for error deployments in quick-input - Use jQuery pattern to avoid Cypress timeout issues when list is loading These changes address timing issues in CI where the webview or quick-input list may not be immediately ready after page load. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add integration test verifying that the last selected deployment is automatically loaded when the extension initializes. This is a regression test for #2459 which was fixed in #2460.
Closes #2473
Type of Change
This is a test addition - so not really any of the below checkboxes.
Approach
Adds a test to validate a regression fix.
User Impact
n/a
Automated Tests
Improves test coverage.
Directions for Reviewers
Checklist