refactor(e2e): replace cy.wait() with assertions for stability#3513
Draft
zackverham wants to merge 5 commits intomainfrom
Draft
refactor(e2e): replace cy.wait() with assertions for stability#3513zackverham wants to merge 5 commits intomainfrom
zackverham wants to merge 5 commits intomainfrom
Conversation
Replace hardcoded cy.wait() calls with proper Cypress assertions and cy.waitUntil() for better test stability and reliability. Changes: - selectors.js: Simplify publisherWebview and getPublisherSidebarIcon using cy.waitUntil() instead of manual recursion with waits - sequences.js: Remove redundant wait after checkbox click, replace recursive section expand with Cypress assertion retry - workbench.js: Use cy.waitForNetworkIdle() and visibility assertions instead of hardcoded waits Reduces cy.wait() calls from 11 to 3 (remaining are intentional backoff in retry utilities). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The previous refactor broke publisherWebview by: 1. Not using the result from cy.waitUntil() 2. Using a CSS selector [src*="extensionId=posit.publisher"] that doesn't work because the src URL contains encoded characters This fix: - Properly chains the waitUntil result through the promise chain - Uses JavaScript filtering (which handles encoded URLs correctly) instead of CSS attribute selectors - Returns the outer iframe body from findPublisherIframeBody() and chains to find the inner active-frame Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded cy.wait() calls with proper Cypress assertions and cy.waitUntil() for better test stability and reliability.
Changes:
Reduces cy.wait() calls from 11 to 3 (remaining are intentional backoff in retry utilities).
Intent
Type of Change
Approach
User Impact
Automated Tests
Directions for Reviewers
Checklist