Foundation for detecting python version requirements from pyproject.toml#643
Merged
Foundation for detecting python version requirements from pyproject.toml#643
Conversation
amol-
force-pushed
the
extract-pyproject-30403
branch
from
158f81a to
5b9035d
Compare
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
Collaborator
Author
|
The failure seems to be already happening on main: https://github.com/posit-dev/rsconnect-python/actions/runs/13663461265/job/38199851576 So marking this as ready for review |
3 tasks
sagerb
approved these changes
Mar 12, 2025
Contributor
sagerb
left a comment
sagerb
left a comment
There was a problem hiding this comment.
This looks great. I only had a little nit about some comments in the test file to better describe what you're doing. I was able to certainly extract what was going on within the code, but for maintenance concerns, I would recommend adding some simple comments as indicated. But I will leave that in your hands to decide!
Collaborator
Author
amol-
force-pushed
the
extract-pyproject-30403
branch
from
5ae6d17 to
5ed8e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Prepare foundations for supporting detection of python version requirements when generating manifest.json.
This implements detect of which metadata file is available and parsing of the requirement from
pyproject.toml.Further changes will provide support for
setup.cfgand.python-version, those will then be used to set the proper requirement field in themanifest.json.Type of Change
Approach
The support for adding python version constraint to
manifest.jsonis being built in small incremental steps that won't change user facing behaviour until the final PR that will enable the new behaviour.Automated Tests
A new test suite in
test_pyproject.pywas added.Directions for Reviewers
There isn't a directly corresponding issue in the
rsconnect-pythonrepository as the issue governing this work is in Connect itself.