Add check_double_prevote and check_double_precommit in vetomint module #508
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junha1
reviewed
Aug 27, 2023
vetomint/src/misbehavior.rs
Outdated
| let byzantine_validator = vote.signer; | ||
| let double_proposal = vote.proposal; | ||
|
|
||
| return vec
There was a problem hiding this comment.
Why early return? What if there are multiple double votes?
jeongseup
force-pushed
the
vetomint/add-function-for-checking-double-votes
branch
from
31b7f14 to
54c808a
Compare
jeongseup
force-pushed
the
vetomint/add-function-for-checking-double-votes
branch
from
54c808a to
14f9c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implement for the issue (#473) and will be merged in other PR (#495) for fully implement other functions to check misbehaviors