Skip to content

Conversation

@susuhahnml
Copy link
Collaborator

No description provided.

@rkaminsk
Copy link
Member

@susuhahnml there is no need to support python 3.7 anymore. Just remove the importlib_metadata part. To get rid of the errors just run pre-commit.

@susuhahnml
Copy link
Collaborator Author

@rkaminsk SHould I also remove the case for python 3.7 in the code then? in the parser.py file

@rkaminsk
Copy link
Member

rkaminsk commented Nov 13, 2024

@rkaminsk SHould I also remove the case for python 3.7 in the code then? in the parser.py file

Yes, please do this. Python 3.9 is the latest release still supported. It is not worth the headache to support earlier versions. We could even drop python 3.9 and go for 3.10 if this makes our lives easier.

@susuhahnml
Copy link
Collaborator Author

Read to merge (I think) @rkaminsk

@rkaminsk rkaminsk merged commit 5295b93 into master Nov 14, 2024
3 checks passed
@rkaminsk rkaminsk deleted the sh/documentation-fix branch November 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants