153. Find Minimum in Rotated Sorted Array #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodchip
reviewed
Aug 10, 2025
| } else if (nums[mid] < nums[right]) { | ||
| right = mid; | ||
| } else { // if (nums[mid] == nums[right]) | ||
| --right; |
|
|
||
| ## 最終コード | ||
|
|
||
| 条件分岐って全部単体のifで回すよりelseとかcontinueとかつけておいた方が余計な条件分岐の判定が少なくなってちょっと早くなるとかあるんでしょうか？ |
There was a problem hiding this comment.
もし気になるようであれば、アセンブラーを出力させて比較したり、マイクロベンチマークを取るとよいと思います。
Owner
Author
There was a problem hiding this comment.
なるほど。アセンブラーを出力するのは考えませんでした。
https://godbolt.org/
このサイトでやってみたところ、x86-64 clang 20.1.0というのでやった場合は-O2, -O3といった最適化オプションを付けた場合は変わらないようです 👀
tokuhirat
reviewed
Aug 11, 2025
|
|
||
| 条件分岐って全部単体のifで回すよりelseとかcontinueとかつけておいた方が余計な条件分岐の判定が少なくなってちょっと早くなるとかあるんでしょうか？ | ||
| コンパイラが勝手に最適化してくれたりすることもあるんですかね。 | ||
| もしかしたらこのelseは少し見づらいかも・・・ |
There was a problem hiding this comment.
全体としては良いと思いました。if 文には {} ついている方が個人的には好みです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題文:
https://leetcode.com/problems/find-minimum-in-rotated-sorted-array/description/