Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions 283/283.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
## 何も見ずに解いてみる

```cpp
class Solution {
public:
void moveZeroes(vector<int>& nums) {
int index = 0;
for (int i = 0; i < nums.size(); ++i) {
if (nums[i] != 0) {
swap(nums[i], nums[index]);
++index;
}
}
}
};
```

## 他の人のコードを見てみる

https://github.com/tokuhirat/LeetCode/pull/54
https://github.com/ryosuketc/leetcode_arai60/pull/54
https://github.com/Ryotaro25/leetcode_first60/pull/59
https://github.com/usatie/leetcode/pull/3

iter_swapというのを使っても書けるみたい。(swap(*it, *non_zero_it++)でも動くには動く)

```cpp
class Solution {
public:
void moveZeroes(vector<int>& nums) {
auto non_zero_it = nums.begin();
for (auto it = nums.begin(); it < nums.end(); ++it) {
if (*it != 0) {
iter_swap(it, non_zero_it++);
}
}
}
};
```

## 最終コード

`non_zero_index`は誤解のないように書けば`index_to_put_next_non_zero_element`ぐらいの名前にしたいが、長くなりすぎるので迷う。
コメントをつけてもいいかも。

```cpp
class Solution {
public:
void moveZeroes(vector<int>& nums) {
int non_zero_index = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non_zero_index でも良いと思います。見方を変えると、これまでに見つかった非ゼロ要素の数なので num_non_zero_items としてもわかりやすいです。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 です

for (int i = 0; i < nums.size(); ++i) {
if (nums[i] != 0) {
swap(nums[i], nums[non_zero_index]);
++non_zero_index;
}
}
}
};
```