-
Notifications
You must be signed in to change notification settings - Fork 0
252. Meeting Rooms #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
potrue
wants to merge
1
commit into
main
Choose a base branch
from
252
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| ここに書いてあるコードはLeetCodeの実行環境上で試せてないので動かないコードがあったら教えてください。 | ||
| (一応LLMに聞いて想定通り動くだろうという回答があったコードではあります) | ||
|
|
||
| ## 何も見ずに解いてみる | ||
|
|
||
| ```cpp | ||
| class Solution { | ||
| public: | ||
| bool canAttendMeetings(vector<vector<int>>& intervals) { | ||
| vector<pair<int, bool>> points; | ||
| for (vector<int>& interval : intervals) { | ||
| points.emplace_back(interval[0], true); | ||
| points.emplace_back(interval[1], false); | ||
| } | ||
| sort(points.begin(), points.end()); | ||
| bool attending = false; | ||
| for (pair<int, bool>& point : points) { | ||
| bool is_start = point.second; | ||
| if (is_start && attending) { | ||
| return false; | ||
| } | ||
| attending = is_start; | ||
| } | ||
| return true; | ||
| } | ||
| }; | ||
| ``` | ||
|
|
||
| ## 他の人のコードを見てみる | ||
|
|
||
| https://github.com/tokuhirat/LeetCode/pull/55/files | ||
| https://github.com/olsen-blue/Arai60/pull/56/files | ||
| https://github.com/ryosuketc/leetcode_arai60/pull/55/files | ||
| https://github.com/Ryotaro25/leetcode_first60/pull/60/files | ||
|
|
||
| 自分のコードでもペアを入れるのではなくmapで実装すればもう少し見通しが良くなったかも。 | ||
| pairのsortがfirstとsecondの辞書順になっていて、さらにtrue > falseであるというのが前提になっているのが良くないかも。 | ||
| せめてコメントがないとわかりにくいような気がする。 | ||
|
|
||
| std::vectorに対するstd::sortは要素を始めから見ていって辞書順に並べ替えるらしい。 | ||
| (1要素目が同じだったら2要素目、2要素目が同じだったら3要素目・・・みたいな感じ) | ||
|
|
||
| ## 最終コード | ||
|
|
||
| sortで中身変えちゃうので値渡しにしました | ||
|
|
||
| ```cpp | ||
| class Solution { | ||
| public: | ||
| bool canAttendMeetings(vector<vector<int>> intervals) { | ||
| sort(intervals.begin(), intervals.end()); | ||
| for (int i = 1; i < intervals.size(); ++i) { | ||
| if (intervals[i][0] < intervals[i-1][1]) { | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
| }; | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どちらかというと operator< の性質でしょうか。
https://en.cppreference.com/w/cpp/algorithm/sort.html
https://en.cppreference.com/w/cpp/container/vector/operator_cmp.html
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、そちらの方が正確ですね。ありがとうございます。