253. Meeting Rooms II #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirat
reviewed
Aug 24, 2025
| } | ||
| int max_num_rooms = 0; | ||
| int num_rooms = 0; | ||
| for (const pair<int, int>& [_, num_change] : time_to_num_change) { |
There was a problem hiding this comment.
上で書かれているように auto を使っても良いかなと思いました。num_change が int だろうと下の行でわかりそうで、使わない _ の型を書くのは微妙かなという理由です。
Owner
Author
There was a problem hiding this comment.
これは確かにそうですね。読むにあたってノイズとなる情報かもしれません。
tokuhirat
reviewed
Aug 24, 2025
| num_rooms += num_change; | ||
| max_num_rooms = max(max_num_rooms, num_rooms); | ||
| } | ||
| return max_num_rooms; |
tokuhirat
reviewed
Aug 24, 2025
| https://github.com/ryosuketc/leetcode_arai60/pull/56/files | ||
| https://github.com/Ryotaro25/leetcode_first60/pull/61/files | ||
|
|
||
| cppのmapやunordered_mapはpythonでいうdefaultdictみたいな振る舞いをするらしい。（[]で存在しない要素にアクセスしようとすると自動でvalueがコンストラクタから初期化される） |
There was a problem hiding this comment.
レファレンスはこの辺りでしょうか。
https://en.cppreference.com/w/cpp/container/map/operator_at.html
Returns a reference to the value that is mapped to a key equivalent to key or x respectively, performing an insertion if such key does not already exist.
ryosuketc
reviewed
Aug 25, 2025
| ++time_to_num_change[interval[0]]; | ||
| --time_to_num_change[interval[1]]; | ||
| } | ||
| int max_num_rooms = 0; |
There was a problem hiding this comment.
好みですが、min_required_rooms などの方が素直に読めそうだなとは思います (ただ関数の返り値であることは明らかなので、これで十分とは思いますが)。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/meeting-rooms-ii/
https://leetcode.ca/2016-08-09-253-Meeting-Rooms-II/