add relative import and change 'print' function to be compatible with python3 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
suggested changes
Feb 5, 2018
vsoch
left a comment
vsoch
left a comment
There was a problem hiding this comment.
Should we remove the checkpoint files? (They were hidden so maybe you missed)
Author
|
Files deleted! |
|
@cehorn this looks reasonable to me, I'm not actually sure why I'm on this repository, but want to hear your feedback on the PR before approving. |
|
Why is this not merged yet? It creates a broken install for anything py>3. Shame |
|
I’m not sure, I’m not a maintainer and agree a merge would be good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.