Open
Conversation
miovd
reviewed
Feb 27, 2019
Contributor
miovd
left a comment
miovd
left a comment
There was a problem hiding this comment.
Please use snake cases to match the names of the config properties of your class
Author
|
Ok It's done |
miovd
requested changes
Feb 28, 2019
miovd
reviewed
Mar 11, 2019
|
|
||
| ## reconnection-initial-interval | ||
|
|
||
| The `reconnection-initial-interval` property is an optional property that defines the initial interval (in seconds) before the first reconnection. Its default values is 5. |
Contributor
There was a problem hiding this comment.
*value
put back-ticks around the default value : *Its default value is 5
|
|
||
| ## reconnection-interval-mutiplier | ||
|
|
||
| The `reconnection-interval-mutiplier` property is an optional property that is used to increase the waiting interval between two reconnection attempts, for example if we wait 5 seconds for the first retry, we will then wait 5*reconnection-interval-mutiplier seconds before the second retry. Its default values is 2. |
Contributor
There was a problem hiding this comment.
*value
put back-ticks around the default value : *Its default value is 2
|
|
||
| ## reconnection-max-interval | ||
|
|
||
| The `reconnection-max-interval` property is an optional property that that defines the max interval in seconds between two reconnections. Its default value is 3600. |
Contributor
There was a problem hiding this comment.
put back-ticks around the default value : *Its default value is 3600
|
|
||
| ## reconnection-max | ||
|
|
||
| The `reconnection-max` property is an optional property that that defines the maximum times in seconds before abandoning the attempts to reconnect. Its default value is Integer.MAX_VALUE. |
Contributor
There was a problem hiding this comment.
put back-ticks around the default value : *Its default value is Integer.MAX_VALUE.
|
|
||
| The `reconnection-max-interval` property is an optional property that that defines the max interval in seconds between two reconnections. Its default value is 3600. | ||
| With the default parameters, there would be no reconnection attempt. | ||
| With autoreconnect-enabled set to true and the other parameters set to default values, in the case of a disconnection, the reconnection attempts would occur after 5", then 10", 20", 40", 1'20", 2'40" .... etc incresing until a maximum of one hour interval. after reconnection max intenal, the reconnection will be re-attempted every hour. |
Contributor
There was a problem hiding this comment.
put back-ticks around default values and property names: *With autoreconnect-enabled set to true
miovd
approved these changes
Apr 8, 2019
Signed-off-by: MASSAOUDI YOUSSEF <youssef.massaoudi@rte-france.com>
yasmas95
force-pushed
the
yasmas95-patch-1
branch
from
472506e to
ca7fd82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.