CP-4131: Tax List V2 Migration #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flongo-godaddy
requested review from
artemkopan,
Copilot,
flongo-godaddy,
lalkhawaja-godaddy and
ylutsenko-godaddy
and removed request for
artemkopan and
flongo-godaddy
flongo-godaddy
changed the base branch from
master
to
feature-branch-commerce-service
flongo-godaddy
approved these changes
Sep 2, 2025
| ) : RecyclerAdapterItem<CatalogTax, TaxItemBinding>(item, onBinding) | ||
| val amountString: String = if (item.tax.amount != null) ( | ||
| item.tax.amount?.amount?.value.toString() + ' ' + item.tax.amount?.amount?.currencyCode | ||
| ) else "N/A", |
There was a problem hiding this comment.
Should it be a localized string from R.string.*? Since we support multiple Locales
| } | ||
|
|
||
|
|
||
| // Step 2: create tax association. Tax Association creates one-to-many relationship, one tax to many products/categories. |
There was a problem hiding this comment.
Do we want to keep the commented code or we can simply remove it?
| private const val DEFAULT_TAX_PRODUCTS_PAGE_SIZE = 100 | ||
| private const val DEFAULT_TAX_PRODUCTS_PAGE_OFFSET = 0 | ||
| } | ||
| enum class DialogType{ |
There was a problem hiding this comment.
The formatting is a bit wrong in many places like here:
// Correct formatting:
enum class DialogType {
ADD_CLASSIFICATION,
ADD_OVERRIDE,
REMOVE_CLASSIFICATION,
REMOVE_OVERRIDE,
NO_SHOW,
}Here is the formatting that we should follow: https://kotlinlang.org/docs/coding-conventions.html#indentation
If you want to fix the formatting all at once, in Android Studio double press "Shift" button and then type "Reformat Code" action. When you select it, it will reformat the entire file correctly according to Kotlin Conventions
| if (id.isNotNullOrBlank()) { | ||
| return@bindTo Toast.makeText( | ||
| requireContext(), | ||
| "Category with id [${id}] was updated", |
There was a problem hiding this comment.
This should be a localized string
ylutsenko-godaddy
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen_recording_20250828_174157.mp4